Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oracle): wire to the App #832

Merged
merged 19 commits into from
Aug 23, 2022
Merged

feat(oracle): wire to the App #832

merged 19 commits into from
Aug 23, 2022

Conversation

testinginprod
Copy link
Collaborator

@testinginprod testinginprod commented Aug 17, 2022

closes: #833

@testinginprod testinginprod changed the title Mercilex/oracle wiring feat(oracle): wire to the App Aug 17, 2022
@testinginprod testinginprod marked this pull request as ready for review August 17, 2022 11:11
@testinginprod testinginprod requested a review from a team as a code owner August 17, 2022 11:11
@@ -96,3 +99,39 @@ func ExecTx(network *Network, cmd *cobra.Command, txSender sdk.AccAddress, args

return resp, nil
}

func (n *Network) SendTx(addr sdk.AccAddress, msgs ...sdk.Msg) (*sdk.TxResponse, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use

func ExecTx(network *Network, cmd *cobra.Command, txSender sdk.AccAddress, args []string, opt ...ExecTxOption) (*sdk.TxResponse, error) {
instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to test multimsg flows, unfortunately I didn't test them here because it was out of the scope.

@testinginprod testinginprod disabled auto-merge August 22, 2022 16:03
@testinginprod testinginprod enabled auto-merge (squash) August 22, 2022 16:04
@testinginprod testinginprod merged commit b3f0d0a into master Aug 23, 2022
@testinginprod testinginprod deleted the mercilex/oracle-wiring branch August 23, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(oracle): wiring
3 participants