Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perps)!: trade limit ratio check in both directions #858

Merged
merged 16 commits into from
Aug 30, 2022
Merged

fix(perps)!: trade limit ratio check in both directions #858

merged 16 commits into from
Aug 30, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Aug 25, 2022 •
edited
Loading

Checks the trade limit ratio in both directions when swapping base or quote assets

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner August 25, 2022 14:20
@NibiruHeisenberg NibiruHeisenberg changed the title feat!(perps): trade limit ratio check fix(perps)!: trade limit ratio check in both directions Aug 25, 2022
@NibiruHeisenberg NibiruHeisenberg self-assigned this Aug 25, 2022
@NibiruHeisenberg NibiruHeisenberg linked an issue Aug 25, 2022 that may be closed by this pull request
fix(perp): SwapQuoteForBase only checks for quote asset, not base asset in trade limit ratio check #771
Closed
@NibiruHeisenberg NibiruHeisenberg enabled auto-merge (squash) August 25, 2022 14:25
@NibiruHeisenberg NibiruHeisenberg changed the title fix(perps)!: trade limit ratio check in both directions fix(perps): trade limit ratio check in both directions Aug 25, 2022
@NibiruHeisenberg NibiruHeisenberg changed the title fix(perps): trade limit ratio check in both directions fix(perps)!: trade limit ratio check in both directions Aug 25, 2022
@NibiruHeisenberg NibiruHeisenberg merged commit 3b962e4 into master Aug 30, 2022
@NibiruHeisenberg NibiruHeisenberg deleted the fix/trade-limit-ratio-check branch August 30, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(perp): SwapQuoteForBase only checks for quote asset, not base asset in trade limit ratio check
2 participants
@NibiruHeisenberg @matthiasmatt