feat(collections): improve development experience #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 6, 2022 10:49
testinginprod
commented
Oct 10, 2022
testinginprod
commented
Oct 10, 2022
collections/iter.go
Outdated
|
|
||
| func (i Iterator[K, V]) Key() K { | ||
| rawKey := append(i.prefixBytes, i.iter.Key()...) | ||
| _, c := i.kc.KeyDecode(rawKey) // todo(mercilex): can we assert safety here? |
There was a problem hiding this comment.
here we can assert key was fully consumed by doing if len(rawKey) != read bytes panic (read bytes is _ currently)
testinginprod
force-pushed
the
mercilex/collections-ux
branch
from
4e48879 to
a3ef64d
Compare
…rcilex/collections-ux # Conflicts: # collections/values_test.go
testinginprod
changed the title
added 2 commits
October 14, 2022 12:54
jgimeno
approved these changes
Oct 14, 2022
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Purpose
Why is this PR important?