Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Update nibiru-proto dependency for v0.14.0 binary #109

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

Unique-Divine
Copy link
Member

No description provided.

@Unique-Divine Unique-Divine marked this pull request as ready for review August 24, 2022 22:20
@Unique-Divine Unique-Divine enabled auto-merge (squash) August 24, 2022 22:21
@Unique-Divine Unique-Divine added the type: test Adding missing tests or improve existing tests label Aug 24, 2022
Copy link
Collaborator

@matthiasmatt matthiasmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deserialize for vpool index price left for later

@@ -49,10 +49,10 @@ def test_query_vpool_all_pools(agent: nibiru.Sdk):

vpool_prices = all_vpool_prices[0]
assert isinstance(vpool_prices["block_number"], int), "block_number"
assert isinstance(vpool_prices["index_price"], float), "index_price"
assert isinstance(vpool_prices["index_price"], str), "index_price"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want str? Is it the function breaking and a way to quickly fix this?

@Unique-Divine Unique-Divine merged commit 7d39001 into master Aug 24, 2022
@Unique-Divine Unique-Divine deleted the binary-v0.14.0 branch August 24, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: test Adding missing tests or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants