test,ci,feat: (1) Use poetry for pkg management. (2) Improve CI. (3) Re-gen protos for v0.12.1-alpha of nibiru #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit bba204296ef2f01d137af0acfd3654920b8262ac Author: Unique-Divine <[email protected]> Date: Fri Aug 12 02:48:08 2022 -0500 add pytest as a non-dev dependency commit bd7f20f1d45ea5ee0e84187f63aec78f7d08f9f4 Author: Unique-Divine <[email protected]> Date: Fri Aug 12 02:43:29 2022 -0500 ci: pytest workflow with poetry first attemp #wip
Unique-Divine
added
type: docs
Unique-Divine
requested review from
matthiasmatt and
NibiruHeisenberg
as code owners
Unique-Divine
force-pushed
the
ud/poetry
branch
from
d975c4b to
23a2d73
Compare
matthiasmatt
requested changes
Aug 12, 2022
matthiasmatt
previously approved these changes
Aug 12, 2022
matthiasmatt
approved these changes
Aug 12, 2022
| mkdir -p nibiru/proto/ | ||
| cp -r ../nibiru/proto/ proto/ | ||
| echo "refresh existing proto files" | ||
| if [ $(basename $(pwd)) = nibiru-py ] |
There was a problem hiding this comment.
Is this if check necessary? make proto-gen will already run in the nibiru-py directory.
There was a problem hiding this comment.
I'm using it as an indirect form of documentation. It's a bit hard to follow this script because the the nibiru repo is assumed to be at ../nibiru, while the nibiru package is ./nibiru and the script actually cds around.
My intention here was to hint at where the execution was taking place.
We should probably add an error message for when the nibiru repo isn't found as well to make the dev exp. a little better.
scripts/protocgen.sh
Outdated
| if [ -d proto ] | ||
| then | ||
| # it will mess up the script, so we preemptively remove it. | ||
| rm -rf proto |
There was a problem hiding this comment.
rm -rf nibiru/proto proto will already delete if it exists, no-op if it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reviewer
You'll need the environment variables listed in the repo configs notion page.
The substance of the PR lies within 5 files:
nibiru/network.py: Created `devnetpyproject.toml(and poetry.lock): Made deterministic build process and used poetry for dependency resolution.github/workflows/.pytests.yml: Verified correctness of the new setup with CItests/chain_info_test.py: Cleaned up tests and added a vpool query to the suitescipts/protocgen.sh: Improved this script to run whether or not the proto directory exists. Added docs to go with it to the README.Summary - Commit Log
poetry#45