This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Add natives package to support node v10 in build #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nickersoft Please review. I think it's better to be able to support the present LTS version of node rather than specifying the deprecated version for the Travis build. |
|
@Nickersoft |
|
Hey @theLufenk! Sorry for the delay! Must have slipped under the radar. LGTM :) |
Nickersoft
approved these changes
Feb 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new LTS version of node as of now is v10. The recent update to node v10 has breaking changes that require the natives package to be installed separately in order to support other other modules that transitively use it.
Fixes: #195