Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_exact_bytes error when the target slice is too large to buffer #14

Merged
merged 8 commits into from
Aug 3, 2024
+620 −29
Merged

Fix read_exact_bytes error when the target slice is too large to buffer #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
936b7c4
Fix read_exact_bytes insufficient buffer size case
NightEule5 Jul 31, 2024
02afe5b
Add tests
NightEule5 Aug 1, 2024
ec04ec4
Update workflow
NightEule5 Aug 1, 2024
d0a4453
Fix slice consume
NightEule5 Aug 1, 2024
1755d55
Merge branch 'refs/heads/main' into fix/small-buffer-read-exact
NightEule5 Aug 3, 2024
51333b3
Fix wrong range in try_read_exact_discontiguous
NightEule5 Aug 3, 2024
9a5656a
Fix inadvertently testing with zero-length buffer
NightEule5 Aug 3, 2024
666e1ed
Fix proptest not compiling
NightEule5 Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,38 @@ env:

jobs:
build:

name: Build
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- run: rustup update nightly
- name: Build
run: cargo build --verbose
- name: Build no_std
- name: Build with no_std
run: cargo build --verbose --no-default-features
- name: Run Clippy
run: cargo clippy --verbose
- name: Run Clippy on no_std
run: cargo clippy --verbose --no-default-features
- name: Run tests
run: cargo test --verbose
- name: Run tests on no_std
run: cargo test --verbose --no-default-features
- name: Build with nightly features
run: cargo +nightly build --verbose --features nightly
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: rustup update nightly && rustup component add --toolchain nightly-x86_64-unknown-linux-gnu clippy
- name: Lint
run: cargo clippy --verbose
- name: Lint with no_std
run: cargo clippy --verbose --no-default-features
- name: Lint with nightly features
run: cargo +nightly clippy --verbose --features nightly
test:
name: Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: rustup update nightly && rustup default nightly
- name: Run tests
run: cargo test --verbose
- name: Run tests on no_std
run: cargo test --verbose --no-default-features
- name: Run tests with nightly features
run: cargo test --verbose --features nightly
Loading