Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Commit

Permalink
Merge pull request #1507 from Akechi-kun/GNB-7.0
Browse files Browse the repository at this point in the history
[GNB] Lv100 fixes & adjustments
  • Loading branch information
Taurenkey authored Jul 12, 2024
2 parents 4b1db62 + 395e5a6 commit d9492ed
Show file tree
Hide file tree
Showing 4 changed files with 129 additions and 95 deletions.
28 changes: 22 additions & 6 deletions XIVSlothCombo/Combos/CustomComboPreset.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using XIVSlothCombo.Attributes;
using XIVSlothCombo.Combos.PvE;
using XIVSlothCombo.Combos.PvP;
using static XIVSlothCombo.Combos.PvE.GNB;

namespace XIVSlothCombo.Combos
{
Expand Down Expand Up @@ -1419,12 +1420,9 @@ public enum CustomComboPreset

#region GUNBREAKER

[CustomComboInfo("Skill Speed Support Feature", "Allows for features to support various skill speed rotations.", GNB.JobID, 0)]
GNB_ST_SkSSupport = 7000,

#region ST
[ReplaceSkill(GNB.KeenEdge)]
[CustomComboInfo("Advanced Gunbreaker Feature", "Replace Keen Edge with its combo chain and uses Burst Strike to prevent ammo overcap.", GNB.JobID)]
[CustomComboInfo("Advanced Gunbreaker Feature", "Replace Keen Edge with its combo chain and uses Burst Strike to prevent ammo overcap. ***DOES NOT WORK WELL WITH 2.46-2.49***", GNB.JobID)]
GNB_ST_MainCombo = 7001,

#region Reign Combo
Expand Down Expand Up @@ -1554,6 +1552,24 @@ public enum CustomComboPreset
GNB_BS_DoubleDown = 7403,
#endregion

#region Fated Circle
[ReplaceSkill(GNB.FatedCircle)]
[CustomComboInfo("Fated Circle Features", "Collection of Fated Circle related features.", GNB.JobID)]
GNB_FC = 7600,

[ParentCombo(GNB_FC)]
[CustomComboInfo("Fated Circle Continuation Feature", "Adds Continuation on Fated Circle.", GNB.JobID)]
GNB_FC_Continuation = 7601,

[ParentCombo(GNB_FC)]
[CustomComboInfo("Fated Circle to Bloodfest Feature", "Replace Fated Circle with Bloodfest if you have no powder gauge.", GNB.JobID)]
GNB_FC_Bloodfest = 7602,

[ParentCombo(GNB_FC)]
[CustomComboInfo("Double Down on Fated Circle Feature", "Adds Double Down to Fated Circle when under No Mercy and ammo is above 2.", GNB.JobID)]
GNB_FC_DoubleDown = 7603,
#endregion

#region No Mercy
[ConflictingCombos(GNB_ST_NoMercy, GNB_AoE_NoMercy)]
[ReplaceSkill(GNB.NoMercy)]
Expand All @@ -1570,7 +1586,7 @@ public enum CustomComboPreset
#endregion

[CustomComboInfo("Aurora Protection Feature", "Locks out Aurora if Aurora's effect is on the target.", GNB.JobID, 0, "", "")]
GNB_AuroraProtection = 7600,
GNB_AuroraProtection = 7700,

[Variant]
[VariantParent(GNB_ST_MainCombo, GNB_AoE_MainCombo)]
Expand All @@ -1587,7 +1603,7 @@ public enum CustomComboPreset
[CustomComboInfo("Ultimatum Option", "Use Variant Ultimatum on cooldown.", GNB.JobID)]
GNB_Variant_Ultimatum = 7035,

// Last value = 7600
// Last value = 7700

#endregion

Expand Down
Loading

0 comments on commit d9492ed

Please sign in to comment.