Feature - NSLog and Print ConsoleWriter #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// During development, it is recommended to use the `.print` case. When deploying to production, the `.nslog` | ||
| /// case should be used. | ||
| /// | ||
| /// - print: The Swift `print` function that is faster, not thread safe and doesn't write to the device console. |
There was a problem hiding this comment.
This would imply that if you have multiple loggers not all using the same queue, the default of .print may lead to crashes?
There was a problem hiding this comment.
Whoops, let me rephrase. Good catch!
cnoon
force-pushed
the
feature/os_log_writer
branch
from
eed7f4c to
e256d30
Compare
cnoon
force-pushed
the
feature/nslog-and-print-console-writer
branch
from
aa62758 to
fde35a6
Compare
|
All comments have been addressed, I'm going to move this PR through. Thanks gents! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Methodenum to theConsoleWriterclass to allow you to select whether to useprintorNSLoginternally. The differences as to using one vs. the other is called out in the enum docstring.The reason to switch between these is that you want to use either the
os_logAPIs orNSLogwhen running on a device. Otherwise, none of the log messages will appear in the device console.