Bugfix - Swift Version File #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnoon
commented
Aug 30, 2017
| @@ -969,7 +979,6 @@ | |||
| PUBLIC_HEADERS_FOLDER_PATH = "$(CONTENTS_FOLDER_PATH)/Headers"; | |||
| SKIP_INSTALL = YES; | |||
| SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; | |||
| SWIFT_VERSION = 3.2; | |||
There was a problem hiding this comment.
All the red throughout the Xcode project files is due to removing overrides that were the same as the project defaults.
ejensen
approved these changes
Aug 30, 2017
EricAppel
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up the
3.0.1release by updating the Xcode project to fully support Xcode 9 and Swift 3.2 as well as bumps the.swift-versionfile for CocoaPods. I'm pushing this PR into ahotfixbranch which we'll use for the release. Then I'll rebase themasterbranch onto thehotfixbranch in preparation for the Willow 4.0.0 release.