This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
* fix issue where removing an assumed-role's SDB permissions will mak… #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the assumed-role lose access to the SDB even if the base IAM role has permissions * fix issue where an assumed-role doesn't inherit base IAM role's admin privileges
fieldju
reviewed
Jan 8, 2019
| @@ -46,6 +46,12 @@ public SafeDepositBoxDao(final SafeDepositBoxMapper safeDepositBoxMapper) { | |||
| return safeDepositBoxMapper.getIamRoleAssociatedSafeDepositBoxRoles(awsIamRoleArn, iamRootArn); | |||
| } | |||
|
|
|||
| public List<SafeDepositBoxRoleRecord> getIamAssumedRoleAssociatedSafeDepositBoxRoles(final String iamAssumedRoleArn, | |||
| final String awsIamRoleArn, | |||
| final String iamRootArn) { | |||
fieldju
reviewed
Jan 8, 2019
| @@ -59,6 +65,12 @@ public SafeDepositBoxDao(final SafeDepositBoxMapper safeDepositBoxMapper) { | |||
| return safeDepositBoxMapper.getIamPrincipalAssociatedSafeDepositBoxes(iamPrincipalArn, iamRootArn); | |||
| } | |||
|
|
|||
| public List<SafeDepositBoxRecord> getAssumedRoleAssociatedSafeDepositBoxes(final String iamAssumedRoleArn, | |||
| final String iamRoleArn, | |||
| final String iamRootArn) { | |||
fieldju
reviewed
Jan 8, 2019
| @@ -27,6 +27,12 @@ Boolean doesIamPrincipalHaveGivenRoleForSdb(@Param("sdbId") String sdbId, | |||
| @Param("iamRootArn") String iamRootArn, | |||
| @Param("rolesThatAllowPermission") Set<String> rolesThatAllowPermission); | |||
|
|
|||
| Boolean doesAssumedRoleHaveGivenRoleForSdb(@Param("sdbId") String sdbId, | |||
| @Param("assumedRoleArn") String assumedRoleArn, | |||
fieldju
reviewed
Jan 8, 2019
| List<SafeDepositBoxRecord> getUserAssociatedSafeDepositBoxes(@Param("userGroups") Set<String> userGroups); | ||
|
|
||
| List<SafeDepositBoxRecord> getUserAssociatedSafeDepositBoxesIgnoreCase(@Param("userGroups") Set<String> userGroups); | ||
|
|
||
| List<SafeDepositBoxRecord> getIamPrincipalAssociatedSafeDepositBoxes(@Param("iamPrincipalArn") final String iamPrincipalArn, | ||
| @Param("iamRootArn") final String iamRootArn); | ||
|
|
||
| List<SafeDepositBoxRecord> getIamAssumedRoleAssociatedSafeDepositBoxes(@Param("iamAssumedRoleArn") final String iamAssumedRoleArn, | ||
| @Param("iamRoleArn") final String iamRoleArn, | ||
| @Param("iamRootArn") final String iamRootArn); |
fieldju
reviewed
Jan 8, 2019
| @@ -42,6 +42,30 @@ | |||
| ) as HAS_PERM; | |||
| </select> | |||
|
|
|||
| <select id="doesAssumedRoleHaveGivenRoleForSdb" resultType="Boolean"> | |||
| SELECT NOT 0 >= ( | |||
fieldju
reviewed
Jan 8, 2019
| @@ -113,6 +113,18 @@ public boolean isRoleArn(final String arn) { | |||
| return iamRoleArnMatcher.find(); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true if the ARN is in format 'arn:aws:iam::000000000:role/example' and false if not | |||
There was a problem hiding this comment.
I think this example arn is for a role arn and not an assume role arn
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e the assumed-role lose access to the SDB even if the base IAM role has permissions