Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: change MIR representation to protobuf #67

Merged
merged 9 commits into from
Jan 14, 2025
Merged

feat!: change MIR representation to protobuf #67

merged 9 commits into from
Jan 14, 2025

Conversation

lumasepa
Copy link
Member

@lumasepa lumasepa commented Dec 16, 2024 •
edited
Loading

Changes

Change MIR representation from json/python dicts to protocol buffers

  • Add protobuf files to the repo
  • Fix mir_proto package packaging adding a Manifest
  • Change the compilation process to use protocol buffers
  • Fix tests to use protocol buffers

This change is not backward compatible.

Merge requirement checklist

  • Unit tests added/updated (if applicable)
  • Backwards compatibility analysis completed (if applicable). "Will this change require recompilation and upload of user programs?"

@lumasepa lumasepa requested a review from a team as a code owner December 16, 2024 16:55
@lumasepa lumasepa requested review from manel1874, jcabrero, pablojhl, nilmemo and mfontanini and removed request for a team December 16, 2024 16:55
@lumasepa lumasepa changed the base branch from fix/nada-type-nada-value-split to main January 14, 2025 09:21
@lumasepa lumasepa merged commit 96ef21b into main Jan 14, 2025
4 checks passed
@lumasepa lumasepa deleted the feat/mir-protobuf branch January 14, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmemo nilmemo nilmemo approved these changes

@pablojhl pablojhl pablojhl approved these changes

@mfontanini mfontanini mfontanini approved these changes

@manel1874 manel1874 Awaiting requested review from manel1874 manel1874 is a code owner automatically assigned from NillionNetwork/lcx

@jcabrero jcabrero Awaiting requested review from jcabrero jcabrero is a code owner automatically assigned from NillionNetwork/lcx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lumasepa @mfontanini @pablojhl @nilmemo @Jmgr