Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'with' statement. #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Jun 29, 2020

This probably still needs some doc changes before it's worth taking, but I thought I'd throw it out there for you.

Fixes #70.

@kousu
Copy link
Contributor Author

kousu commented Jun 29, 2020

Also maybe it shouldn't call finish() if there was an exception? .finish() fills in the whole progress bar to the end?

kousu added a commit to kousu/annexremote-openneuro that referenced this pull request Jun 29, 2020
I also slipped in a workaround for NiltonVolpato/python-progressbar#71
@NiltonVolpato
Copy link
Owner

Also maybe it shouldn't call finish() if there was an exception? .finish() fills in the whole progress bar to the end?

Yeah, finish ensures that the progress bar reaches 100% and prints a newline. If there's an exception you could just print a newline, so the progress bar would be stuck at whatever percentage the exception happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with
2 participants