Pror4 bga + panel #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szszszsz
added a commit
to Nitrokey/nitrokey-pro-firmware
that referenced
this pull request
Jun 18, 2021
Adds better hardware configuration, contained in platform_config.h. If the firmware detects different hardware revision that it was built for, it enters the bootloader mode. Contains other improvements and discoveries, most important listed below. This firmware was tested on both HW rev 3 and 4. Tested on Fedora Linux against: - libnitrokey test suite (libnitrokey v3.6-15-g871a1c9) - GNUK test suite (Nitrokey Start: RTM.10-20-g64f8671) - GnuPG 2.2.20 manual tests - OpenSC 0.20 manual tests Connected: Nitrokey/nitrokey-pro-hardware#20 Fixes #82 Squashed commit of the following: Blink debug LEDs in the development build Boot to the bootloader if flashed firmware does not suit to the hardware Correct compiler flags The -fdata-sections flag influences .text sections from the core drivers, which renders the CCID interface not working, and possibly introduced some other issues, despite having --gc-sections enabled only for the debug build. The -ffunction-sections flag seems to work fine otherwise. Leaving only for the debug builds for now. Debug: prepare test firmware with boot stages LED signalization Stage 1: boot start, before smart card configuration, no LED Stage 2: starting smart card configuration, awaiting for ATR, red LED blinking Stage 3: after smart card configuration, awaiting for USB configuration and connected state, blue/green LED flashes constantly Stage 4: after USB configration, boot process complete, blue/green LED blinking Debug: add ocd helpers for the development Introduce debug build with BUILD_DEBUG=1 switch Removing unused code sections results in a linking error, hence part of the code has to be discarded. To be confirmed, whether this changes the runtime behavior for the release version, and enable there as well. GC of the unused code is required for the development build, which does not fit the flash size otherwise. Mentioned error message: /gcc-arm-none-eabi-8-2018-q4-major/bin/../lib/gcc/arm-none-eabi/8.2.1/../../../../ar m-none-eabi/bin/ld: section .ARM.exidx LMA [000000000800b9cc,000000000800b9d3] overlaps section .data LMA [00000000080 0b9cc,000000000800c02b]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.