Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark experimental configuration settings programmatically #8162

Closed
2 tasks done
fricklerhandwerk opened this issue Apr 4, 2023 · 1 comment · Fixed by #8196
Closed
2 tasks done

Mark experimental configuration settings programmatically #8162

fricklerhandwerk opened this issue Apr 4, 2023 · 1 comment · Fixed by #8196
Assignees

Comments

@fricklerhandwerk
Copy link
Contributor

Problem

Descriptions of experimental settings need the information on "experimentality" baked into the documentation, but this is double book keeping.

Example:

nix/src/libstore/globals.hh

Lines 351 to 359 in d93c151

> **Warning**
> This is an experimental feature.
To enable it, add the following to [`nix.conf`](#):
```
extra-experimental-features = cgroups
use-cgroups = true
```

Given we merge #7798, that information can be displayed automatically, and removed without maintainer intervention if the feature becomes stable. It would also allow more convenient control over presentation, ensuring it will be consistent.

Proposal

Checklist

Priorities

Add 👍 to issues you find important.

@Ericson2314
Copy link
Member

Whoever does this, please feel free to talk to me!

Between those too, this ought to be fairly straight-forward.

@Ericson2314 Ericson2314 self-assigned this Apr 5, 2023
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 10, 2023
Fix NixOS#8162

This is somewhat hard to observe until NixOS#8174 is merged, fixing the
accidental hiding of experimental features that aren't currently
enabled, but the fix is technically orthogonal.
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 11, 2023
Fix NixOS#8162

This is somewhat hard to observe until NixOS#8174 is merged, fixing the
accidental hiding of experimental features that aren't currently
enabled, but the fix is technically orthogonal.
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 12, 2023
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 14, 2023
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 15, 2023
Fix NixOS#8162

The test is changed to compare `nlohmann::json` values, not strings of dumped
JSON, which allows us to format things more nicely.
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 16, 2023
Fix NixOS#8162

The test is changed to compare `nlohmann::json` values, not strings of dumped
JSON, which allows us to format things more nicely.
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 16, 2023
Fix NixOS#8162

The test is changed to compare `nlohmann::json` values, not strings of dumped
JSON, which allows us to format things more nicely.
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Apr 16, 2023
Fix NixOS#8162

The test is changed to compare `nlohmann::json` values, not strings of dumped
JSON, which allows us to format things more nicely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants