-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake check: Recognize well known homeModule/homeModules attribute #10858
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/custom-flake-outputs-for-checks/18877/22 |
While I do think See this issue, though I disagree about |
Successfully created backport PR for |
Do we need |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.22-maintenance
git worktree add -d .worktree/backport-10858-to-2.22-maintenance origin/2.22-maintenance
cd .worktree/backport-10858-to-2.22-maintenance
git switch --create backport-10858-to-2.22-maintenance
git cherry-pick -x 80ba7778e730eccc1afff5a8f53887001bd4ee78 |
I feel this had to add I checked all of resources that I can find but the only thing I found was @shajra's one comment and they are not even code contributor. I think considering how many people actually uses https://github.com/search?q=+language%3ANix+path%3Aflake.nix+homeManagerModule&type=code |
I switched from |
Motivation
This avoids warning fatigue, making nix flake check more effective.
Context
See also #7606 and nix-community/home-manager#1783.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.