Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake check: Recognize well known homeModule/homeModules attribute #10858

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

elohmeier
Copy link
Contributor

Motivation

This avoids warning fatigue, making nix flake check more effective.

Context

See also #7606 and nix-community/home-manager#1783.

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@elohmeier elohmeier requested a review from edolstra as a code owner June 5, 2024 05:34
@github-actions github-actions bot added the new-cli Relating to the "nix" command label Jun 5, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/custom-flake-outputs-for-checks/18877/22

@elohmeier elohmeier changed the title flake check: Recognize well known homeManagerModules attribute flake check: Recognize well known homeModule/homeModules attribute Jun 5, 2024
@roberth
Copy link
Member

roberth commented Jun 5, 2024

While I do think modules.homeManager is preferable, this isn't wrong.

See this issue, though I disagree about configurations.<class>

@roberth roberth merged commit 9d34815 into NixOS:master Jun 5, 2024
10 checks passed
@roberth roberth added the backport 2.22-maintenance Automatically creates a PR against the branch label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Successfully created backport PR for 2.22-maintenance:

@edolstra
Copy link
Member

edolstra commented Jun 5, 2024

Do we need homeModule? Wouldn't it be better to standardize on homeModules.default?

Copy link

Backport failed for 2.22-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.22-maintenance
git worktree add -d .worktree/backport-10858-to-2.22-maintenance origin/2.22-maintenance
cd .worktree/backport-10858-to-2.22-maintenance
git switch --create backport-10858-to-2.22-maintenance
git cherry-pick -x 80ba7778e730eccc1afff5a8f53887001bd4ee78

@nakoo
Copy link

nakoo commented Aug 10, 2024

I feel this had to add homeManagerModule + homeManagerModules too.
2k use case is not a small amount considering homeModules + homeModules only use 0.3k.

I checked all of resources that I can find but the only thing I found was @shajra's one comment and they are not even code contributor. I think considering how many people actually uses homeManagerModules more than this one is more important as Known but unchecked community attribute

https://github.com/search?q=+language%3ANix+path%3Aflake.nix+homeManagerModule&type=code
https://github.com/search?q=+language%3ANix+path%3Aflake.nix+homeModule&type=code

@donovanglover
Copy link
Member

I switched from homeManagerModules to homeModules and like that it's shorter. I think it fits well for merging home-manager into nixpkgs since it's similar to nixosModules.

panchoh added a commit to panchoh/nixos that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.22-maintenance Automatically creates a PR against the branch flakes new-cli Relating to the "nix" command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants