Code

Make goals use C++20 coroutines #11005

Code

Merged

Ericson2314 merged 18 commits intoNixOS:masterNixOS/nix:masterfrom L-as:redo-workerL-as/nix:redo-workerCopy head branch name to clipboardJul 15, 2024

+709-472

Commits

Commits on Jul 15, 2024

• Experiment with using C++20 coroutines in goal code

  L-as

  committed
  721687a

  Copy full SHA for 721687a

• Fix error in new PathSubstitutionGoal logic

  L-as

  committed
  65cfc89

  Copy full SHA for 65cfc89

• Mark Co and Done as nodiscard

  L-as

  committed
  d097493

  Copy full SHA for d097493

• Minor clean-up in worker code

  L-as

  committed
  d6c2c2c

  Copy full SHA for d6c2c2c

• Make coroutines work

  Show description for 35626f7
  L-as

  committed
  35626f7

  Copy full SHA for 35626f7

• Move Co to Goal

  L-as

  committed
  3e5c404

  Copy full SHA for 3e5c404

• Add missing co_await SuspendGoal

  L-as

  committed
  9284cd9

  Copy full SHA for 9284cd9

• Refactor DrvOutputSubstitutionGoal to use coroutines properly

  L-as

  committed
  d767557

  Copy full SHA for d767557

• Make amDone return Co

  L-as

  committed
  e1154d0

  Copy full SHA for e1154d0

• Make coroutines work on GCC

  Show description for 8211454
  L-as

  committed
  8211454

  Copy full SHA for 8211454

• Remove unnecessary logging from coroutine code

  L-as

  committed
  a6a8fda

  Copy full SHA for a6a8fda

• Try to fix weird assertion failure

  L-as

  committed
  97af6d2

  Copy full SHA for 97af6d2

• Fix bug with uninitialized shared_ptr

  L-as

  committed
  608be30

  Copy full SHA for 608be30

• Doc comments in goal.hh

  Show description for ef91247
  L-as

  committed
  ef91247

  Copy full SHA for ef91247

• Convert PathSubstitutionGoal to more idiomatic coroutine code

  Show description for af7ec2d
  L-as

  committed
  af7ec2d

  Copy full SHA for af7ec2d

• libstore/build: Rename SuspendGoal -> Suspend, make amDone return Done instead of Co

  Show description for 4f4945d
  L-as

  committed
  4f4945d

  Copy full SHA for 4f4945d

• Unremove stray line in substitution-goal.cc

  L-as

  committed
  43cfeec

  Copy full SHA for 43cfeec

• Inline PathSubstitutionGoal::handleChildOutput's empty definition

  L-as

  committed
  50c0da5

  Copy full SHA for 50c0da5