Use std::unordered_map for the EvalState caches #11092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
reviewed
Jul 12, 2024
Merged
Ericson2314
approved these changes
Jul 15, 2024
roberth
reviewed
Jul 16, 2024
Comment on lines
+12
to
+13
| #include <boost/functional/hash.hpp> // for boost::hash_combine | ||
|
|
There was a problem hiding this comment.
This wasn't actually used; removing in #11113
Question though: the version in I got from boost was less capable, accepting only two arguments. Did you copy hash_combine from a newer version of boost than our dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is slightly faster and does fewer allocations. Cherry-picked from #10938.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.