Fix relative 'path:' flakerefs in the CLI #12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And handle relative 'git+file:' flakerefs while we're at it (these crashed with an assertion failure). Fixes NixOS#12248.
github-actions
bot
added
the
with-tests
edolstra
added
regression
github-actions
bot
added
the
fetching
edolstra
added a commit
that referenced
this pull request
Jan 15, 2025
…2254 Fix relative 'path:' flakerefs in the CLI (backport #12254)
2 tasks
This was referenced Jan 17, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-15-nix-team-meeting-minutes-208/58993/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #12248.
This also handles relative
git+file:flakerefs while we're at it (these crashed with an assertion failure).Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.