-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading docs: easier to copy + link to issue #2429
Conversation
With `command`, it's easy for users to accidentally copy the period after the command.
This is relevant to #2410. |
Multi-user Nix users on macOS can upgrade Nix by running this: | ||
<screen>$ sudo -i sh -c 'nix-channel --update && nix-env | ||
-iA nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo | ||
launchctl start org.nixos.nix-daemon</screen> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep <command>
but I don't mind dropping the period, and switching to the running this:
part.
<para> | ||
Single-user installations of Nix should run this: | ||
<screen>$ nix-channel | ||
--update; nix-env -iA nixpkgs.nix</screen> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably stick to <command>
and drop the $
prompt.
</para> | ||
|
||
<para> | ||
Single-user installations of Nix should run <command>nix-channel | ||
--update; nix-env -iA nixpkgs.nix</command>. | ||
For more information, see <link xlink:href="https://github.com/NixOS/nix/issues/2410">Issue #2410</link>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep both the old, and the new link as separate paragraphs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree they should be separate. Is the diff viewer displaying this incorrectly?
-iA nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo | ||
launchctl start org.nixos.nix-daemon</command>. | ||
-iA nixpkgs.nix'; sudo launchctl stop org.nixos.nix-daemon; sudo | ||
launchctl start org.nixos.nix-daemon</command> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually reload the service and start the new version? I think this might explain an upgrade issue I noticed yesterday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what it's supposed to do. I've heard of two issues:
- If you have a package installed that depends on
nix
version 1.x, the updated version 2.x might not take over. - For a multi-user installation, you shouldn't install
nix
as the current user.
I included much of this in PR #2434, thank you |
With
command
, it's easy for users to accidentally copy the period after the command.