WIP: add fancy debug logs #3586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
reviewed
May 13, 2020
| @@ -162,7 +163,15 @@ static int _main(int argc, char * * argv) | |||
| bestLoad = load; | |||
| bestSlotLock = std::move(free); | |||
| bestMachine = &m; | |||
| } else { | |||
| debug("skipping '%s': there is a better machine", m.storeUri); | |||
There was a problem hiding this comment.
actually I'm not sure either, but I'm guessing it's based on the parameters above a machine that has a higher speed factor and is available right now
mkg20001
commented
May 13, 2020
| } else { | ||
| debug("skipping '%s': does not meet all condiditions\n - enabled = %s\n - system: type is matching = %s / required %s / got %s\n - features: all supported = %s / mandatory supported = %s / required %s / got %s", m.storeUri, | ||
| m.enabled, | ||
| std::find(m.systemTypes.begin(), m.systemTypes.end(), neededSystem) != m.systemTypes.end(), neededSystem, join(m.systemTypes, ","), |
There was a problem hiding this comment.
the join() function call here should be replaced by the concatStringsSep() one
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.