-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer: improve existing rc backup nag #5524
installer: improve existing rc backup nag #5524
Conversation
@@ -387,19 +387,25 @@ EOF | |||
fi | |||
|
|||
for profile_target in "${PROFILE_TARGETS[@]}"; do | |||
# TODO: I think it would be good to accumulate a list of all | |||
# of the copies so that people don't hit this 2 or 3x in | |||
# a row for different files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would, to be frank, like it to work as commented, and not as coded.
I didn't want to let that pass completely undocumented--but I'm chasing other white whales at the moment and do not have the emotional/intellectual energy to make this happen without an installer test suite that ensures the important bits stay nailed down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some feedback with abathur in a PM on Matrix about point #3 and rewording it a bit, but this looks great to me.
5f24ce9
to
d223050
Compare
I've force-pushed addressing feedback per 3 :) |
d223050
to
f7859ee
Compare
While looking into #5521 I noticed that the installer instructions don't really connect the dots about what the user is expected to do.
This is a tentative rephrase, but I also realize that this kind of thing may well be informed by history--that we're intentionally leaving out steps so that the kinds of people confused by this will ask for help instead of screwing up their systems and trashing us on social.I think GC would've cautioned if this were the case.Objections? @toonn @grahamc @domenkozar
for reference, should look something like: