-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add labeler workflow #6338
add labeler workflow #6338
Conversation
Triaged in Nix team meeting on 2022-11-25:
-> to review |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-11-25-nix-team-meeting-minutes-11/23601/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-12-12-nix-team-meeting-minutes-16/24119/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in Nix team meeting 2023-01-02:
- @fricklerhandwerk: should discuss it again together, given new information on the labelling scheme used by Nixpkgs
- @thufschmitt: this is relevant for maintainers and contributors, and we should delegate to someone to make a proposal giving more context and reasoning
@Artturin, since no one on the Nix team currently has much time to actually deal with the subject in depth, but we agree that developing a process involving labels would help us be more productive - would you like and do you have the capacity to help out here?
Here's what this could entail:
The Nixpkgs workflow is not documented anywhere except for your prior comment. Could you solicit input from maintainers and give more details how the labels are used exactly? And maybe gather some intelligence on other projects (on GitHub or similar) and their labelling schemes and workflows? Then make a PR to sketch rationale, alternatives considered, the proposed system, and how maintainers and contributors should make use of it. It should be lightweight to start with, and extensible with growing needs. I suggest the team would try out ideas from the proposal as we go, and merge it into the maintainer handbook or contributor guide once we settle on something that works.
I imagine that using more structured labels could help keeping an overview, given the procedure is well-documented and followed regularly. They have the advantage that state changes are logged by GitHub, as opposed to when they are moved around the GH project board where the team currently keeps track of issues and PRs.
@NixOS/nix-team Until then I suggest we use the existing labels and merge the automation itself.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-01-02-nix-team-meeting-minutes-20/24403/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Artturin are you still interested in pursuing this?
2d2c385
to
d30e94d
Compare
suggestions applied here's the old # if a label exists in nixpkgs then use that instead of making a new one
"8.has: changelog":
- /doc/manual/src/release-notes/*
"8.has: documentation":
- doc/manual/*
- src/nix/**/*.md
# does not exist in nixpkgs
"8.has: test":
- tests/**/* A another reason to use the same labels as nixpkgs (for issues at least) is that moving a issue uses the same labels when moved from nix to nixpkgs and vice versa |
We discussed this in the Nix team meeting today and agreed we want to do this. Decision: Merge. We were going to do so after this CI failure went away, but I just noticed what I think is a typo. @Artturin can you fix this? |
Head branch was pushed to by a user without write access
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-03-13-nix-team-meeting-minutes-40/26309/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/this-month-in-nix-docs-1-march-2023/26913/1 |
Automatically add labels to pull requests based on the files they touch.
If a label exists in Nixpkgs then use that instead of making a new one.
https://github.com/actions/labeler