-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure attribute listing to derivation
#7320
restructure attribute listing to derivation
#7320
Conversation
e568846
to
4c94db9
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-40/23480/1 |
More broadly, I think if we have #4543 then the |
81584a3
to
3ac3c07
Compare
notes from meeting: realization"Ensure a store path is valid (it and all of its transitive dependencies are in the store); either a derivation's output, or the store path itself if provided directly. When used with a derivation, Nix will either build or substitute the necessary store paths. When used directly with a store path, the necessary store paths will only be substituted, if available." Two cases:
This operation will fail if the supplied derivation/store paths cannot be created by either building or substitution. valid: this is a property of a store path in a store which ensures it and all transitive references to other store paths are readable using that store (for example: on a local FS store this means "on disk").... WIP |
Discussed in Nix team meeting 2022-12-19:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-12-19-nix-team-meeting-minutes-18/24121/1 |
🎉 All dependencies have been resolved ! |
3ac3c07
to
48dc3e9
Compare
derviation
derviation
derivation
I think you have another PR's text stuck in here? |
Ah yeah the force push didn't get through. Will clean it up when I get back to a keyboard. |
48dc3e9
to
a7d0677
Compare
The build failing on linkcheck is very weird, as the highlighted link is actually correct. Checked with @roberth. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-08-21-nix-team-meeting-minutes-81/32082/1 |
d34332c
to
fbcbf95
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-08-28-nix-team-meeting-minutes-83/32290/1 |
Any blockers for merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I look at the rendered view, I see how much this is just a pure reorg. Let's just merge it and worry about content changes separately.
After all, what really should happen is that we rework this content to just be about the store layer, and what is left can just be a much short thing for the builtins.derivation
and builtins.derivationStrict
primops
fbcbf95
to
be26625
Compare
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
derivations are about data transformation, so the term "build" does not add any information. there was also some feedback that "build task" is not more helpful than "derivation" if you have no prior experience with Nix or build systems, while existing associations may be misleading.
make the example more realistic, since `headers` is not an output name used in Nixpkgs Co-authored-by: Robert Hensing <[email protected]>
9bcf5aa
to
5b0336b
Compare
Merging this after addressing all comments and observing that the review seems to converge to minutiae. |
Motivation
The most important part of the language is still documented somewhat sparsely, in somewhat dense language. This is a first step to provide some more predictable structure that is easier to parse.
Context
We still need many more examples and cross-links. This PR starts out on just the structure and the essentials.
Checklist for maintainers
This work is sponsored by Antithesis ✨