Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install command in documentation compatible with fish shell #7474

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

doubledup
Copy link
Contributor

See the description in NixOS/nix.dev/pull/422 for more context.

@edolstra
Copy link
Member

Shouldn't we just use

curl -L https://nixos.org/nix/install | sh

since that works in both shells?

Skip the release notes for now, not sure we want to change these.
@doubledup
Copy link
Contributor Author

@edolstra That's much better, thanks! I've updated the PR and the description. I've also updated some other install commands I found, but left the release notes alone. Is it ok to update the release notes as well?

@doubledup doubledup changed the title Add fish shell install command to documentation Make install command in documentation compatible with fish shell Jan 8, 2023
@doubledup
Copy link
Contributor Author

@fricklerhandwerk @edolstra The nix.dev PR has been merged, but this one seems blocked on some tests that haven't run yet. Is there anything I can do to get the tests running?

@fricklerhandwerk
Copy link
Contributor

I was on vacation, sorry for the delay and thanks for hanging tight. Looks good, I'll merge this.

@fricklerhandwerk fricklerhandwerk enabled auto-merge (squash) February 7, 2023 22:04
@fricklerhandwerk fricklerhandwerk merged commit 9aeaf98 into NixOS:master Feb 7, 2023
@doubledup
Copy link
Contributor Author

No problem at all. Thanks for all your work on Nix!

@doubledup doubledup deleted the patch-1 branch February 10, 2023 10:46
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-team-report-2022-10-2023-03/27486/1

@zegelin
Copy link

zegelin commented Nov 19, 2023

This change has removed --daemon from the quick-start guide's invocation of install.sh.

I'm new to Nix/NixOS, yet it seems like a lot of common internet advice expects Nix to be installed in multi-user mode. Even various Nix wiki pages mention editing /etc/nix/nix.conf and restarting nix-daemon.service (eg: https://nixos.wiki/wiki/NixOS_on_ARM#Compiling_through_binfmt_QEMU, see the Note box for Arch Linux users).

That change also makes the paragraph following the install instructions make no sense:

On Linux, --daemon can be omitted for a single-user install.

There is no --daemon in the invocation to omit!

This change seems to have also missed the https://nixos.org/manual/nix/stable/installation/installation page, which still uses the bash <(curl -L https://nixos.org/nix/install) --daemon style invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants