Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add pull request template #7577

Merged
merged 4 commits into from
Jan 20, 2023
+28 −0
Merged

.github: Add pull request template #7577

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd75693
.github: Add pull request template
roberth Jan 10, 2023
dc9c455
Apply suggestions from code review
roberth Jan 14, 2023
7f04a54
Update .github/PULL_REQUEST_TEMPLATE.md
roberth Jan 20, 2023
dfbdde6
Update .github/PULL_REQUEST_TEMPLATE.md
roberth Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update .github/PULL_REQUEST_TEMPLATE.md
@roberth
roberth authored Jan 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit dfbdde6d07ebb9a4d637221881d93a485f39714c
6 changes: 4 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -18,8 +18,10 @@ Maintainers: tick if completed or explain if not relevant

- [ ] agreed on idea
- [ ] agreed on implementation strategy
- [ ] unit tests
- [ ] functional tests (`tests/**.sh`)
- [ ] tests, as appropriate
- functional tests - `tests/**.sh`
- unit tests - `src/*/tests`
- integration tests
- [ ] documentation in the manual
- [ ] code and comments are self-explanatory
- [ ] commit message explains why the change was made