Tighten up the exportReferencesGraph
tests
#7675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add an
$
at the end of thegrep
regex. Without it,checkRef foo
would always implycheckRef foo.drv
. We want to tell these situations apart to more precisely test what is going on.Context
The came up while @aciceri was kindly helping me out with #7330, in draft PR #7339. Unfortunately the solution I envisioned was not correct, so we'll have to go back to the drawing board. Still, this first commit from that attempt is plain good, and so we should merge it rather than letting it go to waste.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
CC @aciceri @L-as