Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix store ping: add --json flag #7723

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

yorickvP
Copy link
Contributor

Motivation

Requested in #7515 (comment)

Context

I also tried to add a Finally instance to also print the json in case of error, but the store connection happens (and fails) before the run() method is even entered, so this doesn't work. nix show-config --json does work in that case.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

Can you just add a quick test for it? (there's already a store-ping test, you can just extend it)

@roberth
Copy link
Member

roberth commented Jan 31, 2023

cc @MatthewCroughan

@edolstra edolstra enabled auto-merge February 1, 2023 16:10
@edolstra edolstra dismissed thufschmitt’s stale review February 1, 2023 16:11

Comments addressed.

@edolstra edolstra merged commit 7a09bfb into NixOS:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants