Backport 7616 to 2.13 maintenance #7833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were accidentally logged and do not need to appear in make's log output. (cherry picked from commit 1a86d3e)
Set environment variable NIX_DEBUG_SQLITE_TRACES=1 to log all sql statements. (cherry picked from commit 8a0ef5d)
This is slightly more accurate considering that an outdated record may exist in the persistent cache. Possibly-outdated records are quite relevant as they may be foreign keys to more recent information that we want to keep, but we will not return them here. (cherry picked from commit 29f0b19)
This allows testing with a clean database. (cherry picked from commit 79f62d2)
(cherry picked from commit 2ceece3)
Fixes NixOS#3898 The entire `BinaryCaches` row used to get replaced after it became stale according to the `timestamp` column. In a concurrent scenario, this leads to foreign key conflicts as different instances of the in-process `state.caches` cache now differ, with the consequence that the older process still tries to use the `id` number of the old record. Furthermore, this phenomenon appears to have caused the cache for actual narinfos to be erased about every week, while the default ttl for narinfos was supposed to be 30 days. (cherry picked from commit fb94d5c)
And clarify test (cherry picked from commit 19b495a)
roberth
requested review from
fricklerhandwerk,
edolstra and
thufschmitt
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Workaround for Remove push protection from backport branches #7832
Closes [Backport 2.13-maintenance] Fix foreign key error inserting into NARs #3898 #7819
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*