Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/hacking.md: Corrections and additions for cross #7867

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

roberth
Copy link
Member

@roberth roberth commented Feb 20, 2023

Motivation

  • "Target" has a specific meaning in cross-compilation, which does not apply here, and we can avoid the term without loss.
  • Cross compilation wasn't mentioned yet. This isn't a guide to bootstrapping Nix on a platform, but we can't not mention it here, as otherwise the section suggests that emulation is the only way to port Nix.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

@roberth roberth merged commit df6829e into master Feb 20, 2023
@roberth roberth deleted the hacking-cross branch February 20, 2023 21:25
@roberth
Copy link
Member Author

roberth commented Feb 20, 2023

Thanks!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants