Feature gate DownstreamPlaceholder::unknownCaOutput
#8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
This is a part of CA derivations that we forgot to put behind the experimental feature. This was caught by @fricklerhandwerk in NixOS#8369 (comment)
Ericson2314
force-pushed
the
add-another-xp-check
branch
from
89e0d9f to
caabc4f
Compare
8 tasks
edolstra
reviewed
Jul 21, 2023
| DownstreamPlaceholder::unknownCaOutput(drv.drvPath, outputName).render(), | ||
| store->printStorePath(outputPath) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Shouldn't there be an "else" here (like throwing an error)? Seems strange that we can do nothing if CA derivations are not enabled.
There was a problem hiding this comment.
I don't think so actually. It is unclear but basically:
- The only way to get these placeholders is the
outPaths of CA derivation outputs. - If we don't have those, then there is nothing to substitute.
- If someone tried to hand-write one of these (rather than using
outPath, it shouldn't work.
Today, it does work; this is mistakenly a bonus feature that can be used without ca-derivations with careful hand-coding. But I don't think we want that.
thufschmitt
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a part of CA derivations that we forgot to put behind the experimental feature.
Context
This was caught by @fricklerhandwerk in
#8369 (comment)
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.