-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Adapt scheduler to work with dynamic derivations #9415
base: master
Are you sure you want to change the base?
Conversation
This might be a tall order, but could this change be split? |
c6d91e6
to
3d707ef
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/pre-rfc-implement-dependency-retrieval-primitive/43418/9 |
I believe the changes after #11005 will either uncover or silently fix the bug. |
I wouldn't be so sure yet; I haven't rewritten But the subsequent PRs will. |
@L-as yeah, I meant after, and it is only a belief. |
Yeah I think it will help too: there is no more need for outer derivation goal with that change, because we don't need separate types just to have different local variables persisted across yield points. |
Hi all — as a quick status update, did #11005 resolve the issue blocking this from proceeding? If not, any ideas on how to proceed? |
Pretty sure it hasn't. I'm still doing work in this direction that should fix it naturally. |
Yeah looking forward to closing this once @L-as's work obviates it :) |
3d707ef
to
625ed1c
Compare
Motivation
This fixes dynamic derivations, reverting #9081.
#9052 However will be reintroduced unless this is modified somehow.
Context
This reverts commit 8440afb.
Priorities
Add 👍 to pull requests you find important.