Revert 9553 #9568
Merged
Revert 9553 #9568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0ac2a3. The request from the sibling PR, which also applies here, was not addressed. NixOS#9554 (comment)
github-actions
bot
added
the
with-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Revert #9553 because overly long messages are a regression, and the requests made in the similar PR were not applied.
Will be happy to merge a PR that does address all concerns.
This PR also adds an illustrative test.
Context
error: cannot coercemessages #9553Priorities
Add 👍 to pull requests you find important.