Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.19-maintenance] Give Derivation::tryResolve an evalStore argument #9571

Closed

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 9, 2023

Automatic backport to 2.19-maintenance, triggered by a label in #9563.

This is needed for building CA deriations with a src store / dest store
split. In particular it is needed for Hydra.

NixOS/hydra#838 currently puts realizations,
and thus build outputs, in the local store, but it should not.

(cherry picked from commit 96dd757)
@Ericson2314
Copy link
Member

Going to try to finish the CA hydra stuff with this, but won't merge it yet.

@Ericson2314 Ericson2314 closed this Dec 9, 2023
@Ericson2314 Ericson2314 reopened this Dec 9, 2023
Ericson2314 added a commit to obsidiansystems/hydra that referenced this pull request Dec 11, 2023
NixOS/nix#9571

Flake lock file updates:

• Updated input 'nix':
    'github:NixOS/nix/50f8f1c8bc019a4c0fd098b9ac674b94cfc6af0d' (2023-11-27)
  → 'github:NixOS/nix/c4a5f409f167af133b9d917d4c1c23f3f13de06c' (2023-12-09)
@Ericson2314
Copy link
Member

N.B. thufschmitt/hydra#2 Fixed up Hydra CA supporting using this

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero risk, and good as a contingency if Hydra needs to fall back on it.

@tomberek tomberek added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Dec 11, 2023
@Ericson2314
Copy link
Member

I will actually make an even smaller one with both backports and then the idea approved can travel over to that ;)

@Ericson2314
Copy link
Member

#9594 New minimized version

@edolstra edolstra deleted the backport-9563-to-2.19-maintenance branch March 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants