Create ServeProto::BuildOptions and a serializer for it
#9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More tests, and more serializers for Hydra reuse.
github-actions
bot
added
the
store
|
This is rote, very well tested, only following established well-established patterns (not a new sort of refactor from me, as is often the case), so I think I will just merge. If there is an issue with it, per #9577 we can just revert! |
True, but let's not wield this as an excuse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More tests, and more serializers for Hydra reuse.
Context
Priorities
Add 👍 to pull requests you find important.