Give Store::queryDerivationOutputMap and evalStore argument
#9588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
Ericson2314
force-pushed
the
queryDerivationOutputMap-evalStore
branch
from
61dd401 to
ba5349c
Compare
Ericson2314
added a commit
to obsidiansystems/hydra
that referenced
this pull request
Dec 11, 2023
Need backport of NixOS/nix#9588 too Flake lock file updates: • Updated input 'nix': 'github:NixOS/nix/c4a5f409f167af133b9d917d4c1c23f3f13de06c' (2023-12-09) → 'github:obsidiansystems/nix/f49fd6896a409eaeb9a1169f583143e792920b5f' (2023-12-11)
|
N.B. thufschmitt/hydra#2 Fixed up Hydra CA supporting using (a backport of) this. |
|
Needs tests. The best approach may be to provide a mode to run the test suite with a separate eval store. |
|
The |
roberth
approved these changes
Dec 11, 2023
| @@ -604,7 +604,7 @@ void DerivationGoal::inputsRealised() | |||
| return *outPath; | |||
| } | |||
| else { | |||
| auto outMap = worker.evalStore.queryDerivationOutputMap(depDrvPath); | |||
There was a problem hiding this comment.
Small change to CA behavior. Ignores store from now on.
This is in an experimental feature, relating to an already known-broken non-experimental feature.
@Ericson2314 continues to work on this.
There was a problem hiding this comment.
No longer contains this change!
Picking up where NixOS#9563 left off.
Ericson2314
force-pushed
the
queryDerivationOutputMap-evalStore
branch
from
ba5349c to
5f30c8a
Compare
Ericson2314
added
the
backport 2.19-maintenance
roberth
approved these changes
Dec 11, 2023
|
Successfully created backport PR for |
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
…putMap-evalStore Give `Store::queryDerivationOutputMap` and `evalStore` argument (cherry picked from commit 8cddda4) Change-Id: I394e7e11c3f2e0cd3dbe0f48d757c14c09835e44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Picking up where #9563 left off.
Context
Priorities
Add 👍 to pull requests you find important.