allow arbitrary numbers of / in path tails #9722
Conversation
./a/${b} is valid. ./a//${b} is valid. ./a///${b} is invalid. but
./a/${b}///c is valid. this is kind of inconsistent, and considering
that we can do path canonicalization outside of the scanner we may as
well drop the requirement that slash-runs before the first
interpolations be at most 2 long (except for the initial slash of a
path which still needs to be restricted, otherwise we'll create
ambiguities with the update operator).
this should only accept inputs that were invalid previously. the old
behavior of preserving the number of slashes in the final concatenation
expression is kept. we do not canonicalize ~ paths because this would
break the current ability to create paths that'll traverse out of ~.
github-actions
bot
added
the
with-tests
Also, paths starting with two slashes are UNC paths. Since we don't know how to handle those, we should (continue to) disallow them. |
Not necessarily in the parser, but shortly after? Might be simpler that way, and it's good to make it explicitly reserved syntax. (certainly if we don't steal any existing syntax) |
|
we cannot change the path syntax to accept absolute |
|
closing as discussed in favor of keeping the current behavior around for a while longer. |
|
Discussed during the Nix maintainers meeting on 2024-01-22.
We're confused why the the multiple tail slash (`...//...`) examples work today.
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-22-nix-team-meeting-minutes-117/38838/1 |
Motivation
./a/${b} is valid. ./a//${b} is valid. ./a///${b} is invalid. but ./a/${b}///c is valid. this is kind of inconsistent, and considering that we can do path canonicalization outside of the scanner we may as well drop the requirement that slash-runs before the first interpolations be at most 2 long (except for the initial slash of a path which still needs to be restricted, otherwise we'll create ambiguities with the update operator).
this should only accept inputs that were invalid previously. the old behavior of preserving the number of slashes in the final concatenation expression is kept. we do not canonicalize ~ paths because this would break the current ability to create paths that'll traverse out of ~.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.