common-gpu-nvidia: expose architecture modules in nixosModules
#1221
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The architecture-specific modules for `common-gpu-nvidia` are used in the various hardware modules for specific hardware depending on what is needed. This works well, but it would be nice to have these exposed through the flake `nixosModules` so that users using "generic" systems can still access these modules in the same manner as all the others. Such as in my case, I have a desktop system running an Nvidia Ampere GPU, but have to access the `common/gpu/nvidia/ampere` module through its path since it is not exposed in the flake itself. I did not add these to the `README` since none of the other `common-gpu-nvidia` modules are presented there. I opted to follow the trend. I can add them all if suggested.
Mic92
reviewed
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The architecture-specific modules for
common-gpu-nvidiaare used in thevarious hardware modules for specific hardware depending on what is needed.
This works well, but it would be nice to have these exposed through the flake
nixosModulesso that users using "generic" systems can still access thesemodules in the same manner as all the others. Such as in my case, I have a
desktop system running an Nvidia Ampere GPU, but have to access the
common/gpu/nvidia/amperemodule through its path since it is not exposed inthe flake itself.
I did not add these to the
READMEsince none of the othercommon-gpu-nvidiamodules are presented there. I opted to follow the trend. I can add them all if
suggested.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input