Adding support for ga403 #1255
Draft
Adding support for ga403 #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 1, 2024
Mic92
reviewed
Dec 3, 2024
Mic92
reviewed
Dec 3, 2024
Mic92
reviewed
Dec 3, 2024
|
I apologize for the silly mistakes |
Mic92
reviewed
Dec 23, 2024
| boot = { | ||
| # Note: it seems being on the latest kernel is important for CPPC to work, which is required for the amd_pstate | ||
| # https://bugzilla.kernel.org/show_bug.cgi?id=218686 | ||
| kernelPackages = mkDefault pkgs.linuxPackages_latest; |
There was a problem hiding this comment.
Please set a minimum kernel version instead:
kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.X") pkgs.linuxPackages_latest;
Replace x with the kernel version that works for you. In doubt the current latest kernel version if you don't want to test others.
Mic92
reviewed
Dec 23, 2024
| # https://wiki.archlinux.org/title/Iwd#iwd_keeps_roaming | ||
| # | ||
| # But NixOS doesn't have the tweaks for IWD, yet. | ||
| networking.wireless.iwd.settings = |
There was a problem hiding this comment.
This was copied from a different module. Can you move this to a common module?
|
Please undraft when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input