raspberry-pi/4: add LED-disable overlay #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if these options are OK. Please make suggestions. |
Mic92
reviewed
Nov 18, 2023
|
Options look fine to me. Cannot test on actual hardware. |
|
the changes in 89e6821 are not yet tested, but the ones before did work on hardware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
because the
boot.loader.raspberryPi.firmwareConfigwill be deprecated, others might want to disable the LEDs. Found in:https://gist.github.com/SFrijters/206d2c09656affb04284f076c75a1969
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input