-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you did this, I was planning to convert the flake to flake-utils (but probably would have done a worse job), and I was planning to merge the import workflows.
I think it would also be nice to factor the "Building flake-info" step out: make a first job that builds flake-info and pushes it to cachix, and then the two other jobs can fetch it.
👍 I'll do that |
Also, maybe we should use something like https://github.com/Mic92/nix-build-uncached or NixOS/nix#4364 (comment) to avoid a useless "download flake-info from cachix and do nothing with it" step. |
This reverts commit 6c335e6.
Maybe we can worry about that last thing later though, as it seems to be an unresolved issue how to do this properly. |
import-nixpkgs
andimport-flakes
worflows now merged underimport-to-elasticsearch
, but still ran as separate jobs. This will allow us to have one "switch to latest import" job that requires both jobs to succeed.elm files were formatted and not used code removed. Next step is to work on unified search experience for both flakes and nixpkgs, but this will come in next PRs
Use
flake-utils
inflake.nix
to hopefully simplify stuff. More nix cleanup changes should land, but I thought this would be the first step.