Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #450

Merged
merged 9 commits into from
Mar 17, 2022
Merged

Cleanup #450

merged 9 commits into from
Mar 17, 2022

Conversation

garbas
Copy link
Member

@garbas garbas commented Mar 17, 2022

  • import-nixpkgs and import-flakes worflows now merged under import-to-elasticsearch, but still ran as separate jobs. This will allow us to have one "switch to latest import" job that requires both jobs to succeed.

  • elm files were formatted and not used code removed. Next step is to work on unified search experience for both flakes and nixpkgs, but this will come in next PRs

  • Use flake-utils in flake.nix to hopefully simplify stuff. More nix cleanup changes should land, but I thought this would be the first step.

@garbas garbas requested a review from ysndr March 17, 2022 14:00
@garbas garbas self-assigned this Mar 17, 2022
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 17, 2022 20:01 Inactive
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you did this, I was planning to convert the flake to flake-utils (but probably would have done a worse job), and I was planning to merge the import workflows.

I think it would also be nice to factor the "Building flake-info" step out: make a first job that builds flake-info and pushes it to cachix, and then the two other jobs can fetch it.

@garbas
Copy link
Member Author

garbas commented Mar 17, 2022

I think it would also be nice to factor the "Building flake-info" step out: make a first job that builds flake-info and pushes it to cachix, and then the two other jobs can fetch it.

👍

I'll do that

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 17, 2022 21:16 Inactive
@ncfavier
Copy link
Member

RUST_LOG should stay where it is, it's a runtime thing.

Also, maybe we should use something like https://github.com/Mic92/nix-build-uncached or NixOS/nix#4364 (comment) to avoid a useless "download flake-info from cachix and do nothing with it" step.

This reverts commit 6c335e6.
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 17, 2022 21:47 Inactive
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 17, 2022 21:50 Inactive
@ncfavier
Copy link
Member

Maybe we can worry about that last thing later though, as it seems to be an unresolved issue how to do this properly.

@garbas garbas merged commit 26caeaf into main Mar 17, 2022
@garbas garbas deleted the cleanup branch March 17, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants