Skip to content

Commit

Permalink
Merge #247814: python3Packages.jupyterlab_server: run tests
Browse files Browse the repository at this point in the history
  • Loading branch information
vcunat committed Aug 18, 2023
2 parents ee94e76 + 2cf416f commit 2f4e3f6
Showing 1 changed file with 18 additions and 9 deletions.
27 changes: 18 additions & 9 deletions pkgs/development/python-modules/jupyterlab_server/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
, jupyter-server
, tomli
, openapi-core
, pytest-timeout
, pytest-tornasync
, pytest-jupyter
, requests-mock
, ruamel-yaml
, strict-rfc3339
, importlib-metadata
}:

Expand Down Expand Up @@ -47,19 +48,16 @@ buildPythonPackage rec {
nativeCheckInputs = [
openapi-core
pytestCheckHook
pytest-timeout
pytest-tornasync
pytest-jupyter
requests-mock
ruamel-yaml
strict-rfc3339
];

postPatch = ''
# translation tests try to install additional packages into read only paths
rm -r tests/translations/
sed -i "/timeout/d" pyproject.toml
'';

# https://github.com/jupyterlab/jupyterlab_server/blob/v2.15.2/pyproject.toml#L61
doCheck = false;

preCheck = ''
export HOME=$(mktemp -d)
'';
Expand All @@ -70,6 +68,17 @@ buildPythonPackage rec {
"-W ignore::DeprecationWarning"
];

disabledTestPaths = [
"tests/test_settings_api.py"
"tests/test_themes_api.py"
"tests/test_translation_api.py"
"tests/test_workspaces_api.py"
];

disabledTests = [
"test_get_listing"
];

__darwinAllowLocalNetworking = true;

meta = with lib; {
Expand Down

1 comment on commit 2f4e3f6

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat, you pushed a commit directly to master/release branch
instead of going through a Pull Request.

That's highly discouraged beyond the few exceptions listed
on #118661

Please sign in to comment.