Skip to content

Commit

Permalink
python3.pkgs.setuptools: build without bootstrapped-pip
Browse files Browse the repository at this point in the history
  • Loading branch information
tjni authored and FRidh committed Aug 20, 2023
1 parent 253a291 commit 5a9dda2
Showing 1 changed file with 14 additions and 52 deletions.
66 changes: 14 additions & 52 deletions pkgs/development/python-modules/setuptools/default.nix
Original file line number Diff line number Diff line change
@@ -1,73 +1,36 @@
{ stdenv
, lib
, buildPythonPackage
, fetchFromGitHub
, python
, bootstrapped-pip
, lib
, pipInstallHook
, setuptoolsBuildHook
, wheel
}:

let
buildPythonPackage rec {
pname = "setuptools";
version = "67.4.0";
format = "pyproject";

# Create an sdist of setuptools
sdist = stdenv.mkDerivation rec {
name = "${pname}-${version}-sdist.tar.gz";

src = fetchFromGitHub {
owner = "pypa";
repo = pname;
rev = "refs/tags/v${version}";
hash = "sha256-QDHycUFA2VRUE9alan8rF0efZTNV3Jt0CskjkCc+in0=";
name = "${pname}-${version}-source";
};

patches = [
./tag-date.patch
./setuptools-distutils-C++.patch
];

buildPhase = ''
${python.pythonForBuild.interpreter} setup.py egg_info
${python.pythonForBuild.interpreter} setup.py sdist --formats=gztar
# Here we untar the sdist and retar it in order to control the timestamps
# of all the files included
tar -xzf dist/${pname}-${version}.post0.tar.gz -C dist/
tar -czf dist/${name} -C dist/ --mtime="@$SOURCE_DATE_EPOCH" --sort=name ${pname}-${version}.post0
'';

installPhase = ''
echo "Moving sdist..."
mv dist/${name} $out
'';
src = fetchFromGitHub {
owner = "pypa";
repo = "setuptools";
rev = "refs/tags/v${version}";
hash = "sha256-QDHycUFA2VRUE9alan8rF0efZTNV3Jt0CskjkCc+in0=";
};
in buildPythonPackage {
inherit pname version;
# Because of bootstrapping we don't use the setuptoolsBuildHook that comes with format="setuptools" directly.
# Instead, we override it to remove setuptools to avoid a circular dependency.
# The same is done for pip and the pipInstallHook.
format = "other";

src = sdist;
patches = [
./tag-date.patch
./setuptools-distutils-C++.patch
];

nativeBuildInputs = [
bootstrapped-pip
(pipInstallHook.override{pip=null;})
(setuptoolsBuildHook.override{setuptools=null; wheel=null;})
wheel
];

preBuild = lib.optionalString (!stdenv.hostPlatform.isWindows) ''
export SETUPTOOLS_INSTALL_WINDOWS_SPECIFIC_FILES=0
'';

pipInstallFlags = [ "--ignore-installed" ];

# Adds setuptools to nativeBuildInputs causing infinite recursion.
catchConflicts = false;

# Requires pytest, causing infinite recursion.
doCheck = false;

Expand All @@ -77,7 +40,6 @@ in buildPythonPackage {
changelog = "https://setuptools.pypa.io/en/stable/history.html#v${replaceStrings [ "." ] [ "-" ] version}";
license = with licenses; [ mit ];
platforms = python.meta.platforms;
priority = 10;
maintainers = teams.python.members;
};
}

0 comments on commit 5a9dda2

Please sign in to comment.