apptainer, singularity: warn abuot argument deprecation

Warn when arguments newuidmapPath and newgidmapPath is used. (cherry picked from commit c3026ac)
NixOS · Jul 3, 2024 · 77442cf · 77442cf
1 parent 8993f1f
commit 77442cf
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/pkgs/applications/virtualization/singularity/generic.nix b/pkgs/applications/virtualization/singularity/generic.nix
@@ -116,11 +116,15 @@ let
     if ((newuidmapPath == null) && (newgidmapPath == null)) then
       null
     else
-      runCommandLocal "privileged-un-utils" { } ''
-        mkdir -p "$out/bin"
-        ln -s ${lib.escapeShellArg newuidmapPath} "$out/bin/newuidmap"
-        ln -s ${lib.escapeShellArg newgidmapPath} "$out/bin/newgidmap"
-      '';
+      lib.warn
+        "${pname}: arguments newuidmapPath and newgidmapPath is deprecated in favour of systemBinPaths."
+        (
+          runCommandLocal "privileged-un-utils" { } ''
+            mkdir -p "$out/bin"
+            ln -s ${lib.escapeShellArg newuidmapPath} "$out/bin/newuidmap"
+            ln -s ${lib.escapeShellArg newgidmapPath} "$out/bin/newgidmap"
+          ''
+        );
 
   # Backward compatibility for privileged-un-utils.
   # TODO(@ShamrockLee): Remove after Nixpkgs 24.05 branch-off.