Skip to content

Commit

Permalink
flutterPackages-source.v3_24: disable test building when checks are d…
Browse files Browse the repository at this point in the history
…isabled
  • Loading branch information
RossComputerGuy committed Aug 27, 2024
1 parent a2b56cd commit bf4565a
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions pkgs/development/compilers/flutter/engine/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,9 @@ stdenv.mkDerivation (finalAttrs: {
"--linux-cpu ${constants.alt-arch}"
]
++ lib.optional (!isOptimized) "--unoptimized"
++ lib.optional (runtimeMode == "debug") "--no-stripped";
++ lib.optional (runtimeMode == "debug") "--no-stripped"
++ lib.optional finalAttrs.doCheck "--enable-unittests"
++ lib.optional (!finalAttrs.doCheck) "--no-enable-unittests";

# NOTE: Once https://github.com/flutter/flutter/issues/127606 is fixed, use "--no-prebuilt-dart-sdk"
configurePhase =
Expand Down Expand Up @@ -305,10 +307,12 @@ stdenv.mkDerivation (finalAttrs: {
runHook preInstall
rm -rf $out/out/$outName/{obj,gen,exe.unstripped,lib.unstripped,zip_archives}
rm $out/out/$outName/{args.gn,build.ninja,build.ninja.d,compile_commands.json,display_list_rendertests,flutter_tester,toolchain.ninja}
rm $out/out/$outName/{args.gn,build.ninja,build.ninja.d,compile_commands.json,toolchain.ninja}
find $out/out/$outName -name '*_unittests' -delete
find $out/out/$outName -name '*_benchmarks' -delete
'' + lib.optionalString (finalAttrs.doCheck) ''
rm $out/out/$outName/{display_list_rendertests,flutter_tester}
'' + ''
runHook postInstall
'';

Expand Down

0 comments on commit bf4565a

Please sign in to comment.