Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fetchFromGitHub support submodules #15559

Closed
copumpkin opened this issue May 19, 2016 · 3 comments
Closed

Make fetchFromGitHub support submodules #15559

copumpkin opened this issue May 19, 2016 · 3 comments
Labels
0.kind: enhancement Add something new

Comments

@copumpkin
Copy link
Member

Currently if your source bundle uses git submodules, you either need to use fetchgit or manually string together fetchFromGitHub invocations to plug them into the relevant locations.

The former already works, but is less efficient than it needs to be. The latter could be done by calling fetchFromGitHub recursively, parsing the .gitmodules file, and pulling out submodules as needed. The submodules could themselves be fetched with the equivalent of fetchgit (with non-GH submodules, assuming its builder script is reusable) or fetchFromGitHub (if the submodules come from GH)

@domenkozar
Copy link
Member

There are a few packages using fetchgit for this reason, we should port them when this is done as a proof of concept

@Profpatsch
Copy link
Member

The current fix uses fetchgit as Fallback, ideally we’d like to have a recursive fetchtar/fetchzip.

@therealpxc therealpxc mentioned this issue Mar 24, 2017
7 tasks
@matthewbauer
Copy link
Member

I believe this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new
Projects
None yet
Development

No branches or pull requests

5 participants