Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchFromGithub doesn't work with fetchSubmodules when using tag as rev #27180

Closed
nh2 opened this issue Jul 6, 2017 · 2 comments
Closed

fetchFromGithub doesn't work with fetchSubmodules when using tag as rev #27180

nh2 opened this issue Jul 6, 2017 · 2 comments

Comments

@nh2
Copy link
Contributor

nh2 commented Jul 6, 2017

I'm trying

  src = fetchFromGitHub {
    owner = "KDAB";
    repo = "hotspot";
    rev = "v1.0.0";
    sha256 = "09ly15yafpk31p3w7h2xixf1xdmx803w9fyb2aq7mhmc7pcxqjsx";
    fetchSubmodules = true;
  };

But when building I just get Bad commit hash or bad reference..

It works when I change to an explicit SHA (rev = "352687bf620529e9887616651f123f922cb421a4";).

It also works when I remove fetchSubmodules = true;.


CC @copumpkin; original support for fetchSubmodules in fetchFromGithub was added in #15559

@nh2
Copy link
Contributor Author

nh2 commented Jul 6, 2017

You're right, it's a duplicate.

@nh2 nh2 closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@nh2 and others