-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongodb: 4.0, 4.2, 4.4 and 5.0 broken at master #171928
Comments
Hi,
This points to master shortly after the PR was merged. |
macOS is locked to an older version: https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/nosql/mongodb/5.0.nix#L14 |
Yes, I know. :) could you check the revision I mentioned. |
Nixpkgs at commit: a7cf937
|
Ok. So it should be possible to bisect this. I can try to look into this later. But you are happy to take a stab at finding out wich commit introduced the regression. |
My bisect attempt pointed first failure to: 999a16c (PR #168737) Previous commit (f3803e3) builds fine. But. I had to cheat. Because |
I think the problem is related to the GCC11 update. Gentoo has a patch for it until this if fixed upsteam. Maybe we should apply this one too. |
Nice. Yes, this should fix the issue with |
|
Yes I can build (or atleast start the build) with 92402c9 (mongodb: 5.0.5 -> 5.0.7). Also, I had forgotten how heavy it was to compile mongo :P |
Hmm both seems to relate with @bachp comment (#171928 (comment)). |
Trying the patch... |
Also for MongoDB v4.0 this patch may be needed: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-db/mongodb/files/mongodb-5.0.2-glibc-2.34.patch |
Arround one hour in MongoDB 4.4 compilation, I think that's safe to assume that the patch worked. I will cancel it and try 4.2 and 4.0. EDIT did not needed to cancel, it worked!
|
4.2 worked, 4.0 did not, testing with the other patch... |
Ok with some adjusts this patch worked, so 4.0, 4.2 and 4.4 is building now (sending a PR in a few minutes), still need to sort de OpenSSL problem with 5.0... EDIT PR https://github.com/NixOS/nixpkgs/pull/172009/files |
I am hitting this https://github.com/mongodb/mongo/blob/master/SConstruct#L4076 do not know exactly why yet. |
Yep, scons seems to not be picking up the environment set by Nix. The interesting thing is that this used to work and broke at some point. See #171928 (comment) |
Interesting note on As a test, try to lock At
At
Add My host is under powered to build mongodb. So I don't know if this works. |
I've suspected something similar. Diffing the two commits that you bisected shows that a notable difference is that the one that works uses gcc10 and the one that doesn't uses gcc11. I've been building gcc10 for over an hour now. Let's see whether the installation of 5.0 works after that. |
Thanks for the tip! It at least pass the OpenSSL check and starts building, will report once it completes. Yet, its still obscure to me why GCC version will implicate a problem with the OpenSSL check. EDIT wait I was adding openssl.dev to the buildInputs, will remove and restart. EDIT 2 build passed the OpenSSL check, the glibc patch from Gentoo probably won't be needed since we are now using GCC10 dropping it and restarting the build. |
Sorry for the late reply. I can confirm this works. |
Thanks! Pushing this commit now! I still need to update the docs, after that I think we are good to go :D Also editing OP to thanks @superherointj ! |
About when can we expect this issue to be fixed? |
I have extracted the fix for 4_0 and 4_2, in case that helps you. 4_4 and 5 still errors. (There was some other newer change that broke it (again). I haven't bisected it.) |
When my PC doesn't heat up the whole room trying to build this :P Jokes aside, just like @superherointj said, I got it to build, then it has broken again and times limited what I can invest right now to fix it.
Will do it, thanks. At least, for now, we should have a 4.0 and 4.2 working. As soon as I have some time I will try to dig in #172009 and rebase with #178881. |
Sorry I used the work fix but it won't fix completely so I reworded but you get 2 GitHub link. I managed to build mongod v5 (in nix-shell) with I took a commit of master that doesn't need to drop gcc version.
The reason was it copy and donc move it. Do you think hydra can add exception to MongoDB once all free versions are dropped ? |
Thanks for the input, but sorry I did not fully understood your message. 600Go = GCC? About Hydra and MongoDB I think not, see here #83433 and here #83884 for context. The problem between nixos-rebuild and nix-shell maybe the appointing to nixpkgs, if you use flakes you should change your input to your repo and if not set NIX_PATH or something along those lines. I highly suggest using Sadly, with MongoDB license, I am just fixing it because I want it fixed, building it here takes a bit of time and since the client itself was my main interest this gives little practical usage for me, of course, in a server it will be probably quick enough and since there's no need to update it often, it might get way with it. |
the default target is: The issue was my /nix/store is mounted on disk that didn't have enough space to copy binary from /tmp I just resized and relaunched. I see the logs and nixos-rebuild took the correct nixpkgs and managed to build |
Can this issue be closed ? |
Great catch! Based on the latest comments of #172009 (comment) and no new issues, I think we can. |
Just to verify, this PR did not fix mongodb 5.0 on OSX and left it marked broken right? I tried building it anyway with a recent nixpkgs to verify it it actually broken with the scons error:
|
In October it builded. Maybe another regression (since it is non free hydra doesn't check it) just open a new issue (if none is already open) |
Mongodb-4_4 (required by Unifi) doesn't compile with the latest unstable:
|
@Et7f3 @alexvorobiev mongodb_4-4 does not build. Maybe for a different reason, I don't know. |
Describe the bug
MongoDB 4.4 and 5.0 is currently broken in master.
Steps To Reproduce
mongodb-5_0
ormongodb-4.4
.Expected behavior
Screenshots
N/A
Additional context
My old PR: #146324 (comment)
For 5_0:
For 4.4:
Notify maintainers
@bluescreen303 @offline @cstrahan @kfiz @otavio @bachp
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.The text was updated successfully, but these errors were encountered: