Restic: Service assumes --files-from is in use.

[hughobrien]

Describe the bug

Recent changes to the nixos/modules/services/backup/restic.nix assume the presence of the --files-from list even when it is not in use (it defaults to null). This prevents the service from running.

Problem line:

nixpkgs/nixos/modules/services/backup/restic.nix

Line 338 in 26ad83b

ExecStart = (optionals doBackup [ "${resticCmd} backup ${concatStringsSep " " (backup.extraBackupArgs ++ excludeFlags)} --files-from=${filesFromTmpFile}" ])

Steps To Reproduce

Steps to reproduce the behavior:

1. Create a backup service without the 'dynamicFilesFrom' option
2. Observe that --files-from= is included in the service's ExecStart
3. Observe service failing due to no such file or directory error

Expected behavior

Argument should not be passed if dynamicFilesFrom is not in use

Screenshots

Additional context

Notify maintainers

@i077 @mbrgm @dotlambda

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.9, NixOS, 23.11 (Tapir), 23.11.20231029.0cbe9f6`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

[hughobrien]

cc @robryk

[robryk]

Please provide the relevant part of your configuration hughobrien ***@***.***> schrieb am Mi., 1. Nov. 2023, 01:07:

…

cc @robryk <https://github.com/robryk> — Reply to this email directly, view it on GitHub <#264696 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALHHI4BAUQ22Z2G43GQCBDYCGHFHAVCNFSM6AAAAAA6YQAL52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGE4TSNZQGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[hughobrien]

The problematic section is unconditional so I do not believe the config matters. Nevertheless

    restic.backups = {
      "${hostName}" = {
        paths = [ "/home/${user}" "/persist" ];
        repository = "sftp:storage:restic-${hostName}";
        passwordFile = "/persist/restic/storage-pass";
        user = "root";
        extraBackupArgs = [ "--verbose" "--compression=max" "--exclude-file=/persist/restic/storage-exclude" ];
        extraOptions = [ "sftp.command='ssh storage -F /persist/restic/config -s sftp'" ];
        pruneOpts = [ "--keep-daily 14" "--keep-weekly 12" "--keep-monthly 18" "--keep-yearly 100" ];
        checkOpts = [ "--with-cache" ];
        timerConfig = {
          OnCalendar = "05:00";
          RandomizedDelaySec = "30m";
        };
      };

× restic-backups-fw.service
     Loaded: loaded (/etc/systemd/system/restic-backups-fw.service; linked; preset: enabled)
     Active: failed (Result: exit-code) since Wed 2023-11-01 05:28:29 EDT; 4h 38min ago
TriggeredBy: ● restic-backups-fw.timer
    Process: 136119 ExecStart=/nix/store/wigwy3s2kssq28z2nxjxyqc2yqd6ckvq-restic-0.16.1/bin/restic -o sftp.command=ssh storage -F /persist/restic/config -s sftp backup --verbose --compression=max --exclude-file=/persist/restic/storage-exclude --files-from=/run/restic-backups-fw/includes (code=exited, status=1/FAILURE)
   Main PID: 136119 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 10ms

Nov 01 05:28:29 fw systemd[1]: Starting restic-backups-fw.service...
Nov 01 05:28:29 fw restic[136119]: open /run/restic-backups-fw/includes: no such file or directory
Nov 01 05:28:29 fw systemd[1]: restic-backups-fw.service: Main process exited, code=exited, status=1/FAILURE
Nov 01 05:28:29 fw systemd[1]: restic-backups-fw.service: Failed with result 'exit-code'.
Nov 01 05:28:29 fw systemd[1]: Failed to start restic-backups-fw.service.

[robryk]

Ah, I see. I'll send a fix in the evening. In the meantime, you can work around the problem by setting `initialize = true;` (which does not change anything if the repository already exists). hughobrien ***@***.***> schrieb am Mi., 1. Nov. 2023, 15:08:

…

The problematic section is unconditional so I do not believe the config matters. Nevertheless restic.backups = { "${hostName}" = { paths = [ "/home/${user}" "/persist" ]; repository = "sftp:storage:restic-${hostName}"; passwordFile = "/persist/restic/storage-pass"; user = "root"; extraBackupArgs = [ "--verbose" "--compression=max" "--exclude-file=/persist/restic/storage-exclude" ]; extraOptions = [ "sftp.command='ssh storage -F /persist/restic/config -s sftp'" ]; pruneOpts = [ "--keep-daily 14" "--keep-weekly 12" "--keep-monthly 18" "--keep-yearly 100" ]; checkOpts = [ "--with-cache" ]; timerConfig = { OnCalendar = "05:00"; RandomizedDelaySec = "30m"; }; }; × restic-backups-fw.service Loaded: loaded (/etc/systemd/system/restic-backups-fw.service; linked; preset: enabled) Active: failed (Result: exit-code) since Wed 2023-11-01 05:28:29 EDT; 4h 38min ago TriggeredBy: ● restic-backups-fw.timer Process: 136119 ExecStart=/nix/store/wigwy3s2kssq28z2nxjxyqc2yqd6ckvq-restic-0.16.1/bin/restic -o sftp.command=ssh storage -F /persist/restic/config -s sftp backup --verbose --compression=max --exclude-file=/persist/restic/storage-exclude --files-from=/run/restic-backups-fw/includes (code=exited, status=1/FAILURE) Main PID: 136119 (code=exited, status=1/FAILURE) IP: 0B in, 0B out CPU: 10ms Nov 01 05:28:29 fw systemd[1]: Starting restic-backups-fw.service... Nov 01 05:28:29 fw restic[136119]: open /run/restic-backups-fw/includes: no such file or directory Nov 01 05:28:29 fw systemd[1]: restic-backups-fw.service: Main process exited, code=exited, status=1/FAILURE Nov 01 05:28:29 fw systemd[1]: restic-backups-fw.service: Failed with result 'exit-code'. Nov 01 05:28:29 fw systemd[1]: Failed to start restic-backups-fw.service. — Reply to this email directly, view it on GitHub <#264696 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALHHI7XUBSTBIPT3HQ3EGTYCJJWZAVCNFSM6AAAAAA6YQAL52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGAZDCOBSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>