-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: change the occurrences of "name" to "pname-version" #104662
Conversation
For some requests, I had to leave comments instead of suggestions as GitHub seems to limit how many lines around a change you can make a suggestion on |
@RaghavSood many thanks! For now I am just changing the most obvious things. |
Certainly - most of my suggestions are simply to fix up stuff missed in the initial commit - the only one that is an actual issue is The rest are just adding on to the legwork you already did in updating most scenarios :) |
For now just point the lines. |
While there is certainly consensus to use Either way thanks for working on this! |
Conversely, if the project has changed their repo name, there's usually a good chance that they are changing the project name, in which case I'm not really sure on how often a project + repo renames vs. just renaming the repo, I can't imagine it being terribly common in either scenario - we might see one or two a month across the entire tree |
There are some rare but noteworthy exceptions. For now my concerns are
|
Why does it rebuild the world? |
/rebase-staging |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)